Resolve scopes relative to import map base #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
reviewed
Jul 28, 2019
| @@ -156,8 +156,7 @@ function applyPackages (id, packages) { | |||
| const pkgName = getMatch(id, packages); | |||
| if (pkgName) { | |||
| const pkg = packages[pkgName]; | |||
| if (pkg === null) | |||
|
|
|||
| if (pkg === null) return; | |||
There was a problem hiding this comment.
Is this fixing an existing bug? Looks like we just had an if statement without a block afterwards?
There was a problem hiding this comment.
Yup! The validation was never applying 😲
joeldenning
approved these changes
Jul 30, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #1968 in resolving scopes relative to the baseUrl, as was implemented in the import maps spec update.
As a major change this will form a SystemJS v5, so it's worth thinking about if we have any other major changes we'd like to add to the mix before merging and releasing here.