fix(extras): avoid to check frames in global import #1973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
Jul 24, 2019
it has the same behavior Co-Authored-By: Guy Bedford <guybedford@gmail.com>
|
Thanks for review ! |
guybedford
reviewed
Jul 30, 2019
| @@ -29,7 +30,8 @@ function noteGlobalProps () { | |||
| // but this may be faster (pending benchmarks) | |||
| firstGlobalProp = secondGlobalProp = undefined; | |||
| for (let p in global) { | |||
| if (!global.hasOwnProperty(p)) | |||
| // do not check frames cause it could be removed during import | |||
| if (!global.hasOwnProperty(p) || (!isNaN(p) && p < global.frames.length)) | |||
There was a problem hiding this comment.
Should we change this one as well?
|
Sorry for the delayed response - that sounds good to me. Will definitely merge this for the next release then! |
|
Merged manually in 9da282e. |
|
Released in 4.1.1. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid to check frames when comparing properties
eg: routing from a page with iframe to a new page which import global.
Then, the iframe is unmounted during import and "global" value is not the same between noteGlobalProps and getGlobalProp.