Named register extra #1855
Merged
Named register extra #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative to origin-relative might be to make the bundle namespace its own URL space: So the workflow would be: bundle.js System.register('app/x', ...)
System.register('app/y', ...)With usage: await System.import('./bundle.js');
const mx = await System.import('bundle:app/x');Perhaps that is more obvious than origin-relative resolution. Is |
guybedford
force-pushed
the
named-register
branch
from
df4e2f1 to
36c7559
Compare
|
I've updated this branch to use the I think this seems like a good approach, will merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new drop-in extra for
System.register('name', ...bundles support.Normalization is handled by simply appending to the origin -
System.register('namebecomeshttps://site.com/name.So imports will work as long as the resolved URLs match this -
System.import('/name')orSystem.import('//site.com/name')would work in the above.