Fixed crash on startup caused by missing cfg options in certain scl drivers #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therandomstring
added a commit
that referenced
this pull request
Oct 31, 2024
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
HofiOne
requested changes
Nov 4, 2024
therandomstring
added a commit
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
therandomstring
force-pushed
the
fix-cfg-nullptr-crash
branch
from
57e6b9a to
73f86f0
Compare
HofiOne
requested changes
Nov 4, 2024
…scl drivers Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
therandomstring
force-pushed
the
fix-cfg-nullptr-crash
branch
from
73f86f0 to
0d64f2f
Compare
HofiOne
approved these changes
Nov 4, 2024
|
Build FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain SCL drivers have options without default values. This could (and in certain cases does) result in
_report_generator_argstrying to iterate on a nullpointer, and crashing syslog-ng in the process.