Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pluto] - fixed annotation positioning with dynamic grid items #994

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

emilbon99
Copy link
Contributor

@emilbon99 emilbon99 commented Dec 17, 2024

Issue Pull Request

Key Information

Description

Fixes an issue where enabling and disabling the title on the plot itself results in the annotation being incorrectly positioned.

Basic Readiness

  • I have performed a self-review of my code.
  • I have added relevant tests to cover the changes to CI.
  • I have added needed QA steps to the release candidate template that cover these changes.
  • I have updated in-code documentation to reflect the changes.
  • I have updated user-facing documentation to reflect the changes.

Backwards Compatibility

Data Structures

I have ensured that previous versions of stored data structures are properly migrated to new formats in the following projects:

  • Server
  • Console

API Changes

The following projects have backwards-compatible APIs:

  • Python Client
  • Server
  • TypeScript Client

Breaking Changes

Copy link
Contributor

@pjdotson pjdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the pluto version.

PR is approved after comment is addressed + version is bumped.

@@ -9,7 +9,7 @@

import "@/index.css";
import "@synnaxlabs/media/dist/media.css";
import "@synnaxlabs/pluto/dist/pluto.css";
// import "@synnaxlabs/pluto/dist/pluto.css";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment

@emilbon99 emilbon99 requested a review from pjdotson December 19, 2024 22:39
@emilbon99
Copy link
Contributor Author

Please merge once you re-review

@pjdotson pjdotson merged commit 3723d9a into main Dec 19, 2024
36 checks passed
@pjdotson pjdotson deleted the sy-1720-fix-annotation-grid-positioning branch December 19, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants