Sy 1805 fix setpoint over activating #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjdotson
approved these changes
Dec 31, 2024
…5-fix-setpoint-over-activating
emilbon99
added a commit
that referenced
this pull request
Jan 1, 2025
* update dependencies * update go dependencies * update earthfiles * Hide variable density channels in create channel modal (#999) * SY-1723 Fix ESLint Config and Lint (#1003) * Validate read task configuration before configuring (#1002) * SY-1586 Allow Renaming Schematic Snapshots from Tab Name (#1001) * Auto Update JSON File * SY-1310 Block Passing Non-CSV Files to Table Scaling (#993) * SY-1178 Add Snapshot to Schematic Toolbar (#998) * SY-1509 Add Demo Cluster to Default Clusters and Fix Issues with Copying Local Cluster Link (#1000) * Auto Update JSON File * Auto Update JSON File * SY-1635 Remove Orientation Selector from Schematic Switch and Button (#992) * Auto Update JSON File * [console] - added workspace exclusion functionality (#1006) * Sy 850 position groups above items in resources tree (#1005) * [console] - added priority group resource sorting * [console] - updated ontology tree sorting algorithm to correctly sort groups * Auto Update JSON File * Auto Update JSON File * [pluto] - fixed issues with table rendering (#1014) * [pluto] - setpoint styling improvements (#997) * [pluto] - setpoint styling improvements * [pluto] - added specs for nan checks on inputs * [pluto] - setpoint touchups * [pluto] - removed extra file * [pluto] - fixed bad code in schematic symbol previews * [pluto] - made default set point color darker * Auto Update JSON File * [pluto] - added option to disable editable text outline * Auto Update JSON File * [pluto] - added escape propagation prevention to input elements (#1004) * [pluto] - added escape propagation prevention to input elements * [pluto] - added focus trapping to modals * [pluto] - fixed schematic edge coloring (#1017) * Auto Update JSON File * SY-1758 Fix Python Client Examples (#1016) * Schematic Symbols (#1012) * flowmeter-general * the F is INSIDE now :o * F text scales as well * electromagnetic, variable area, coriolis * nozzle venturi ring piston * positive displacement, turbine, pulse, float sensor * cross junction * heat exchangers * pumps and compressors * agitators * flame arrestors * valves * coloring * Sy 1764 improve docs site details and summary (#1013) * [docs/site] - improved summary and details components * [docs/site] - added links to each documentation element * [docs/site] - removed extra dependencies * [docs/site] - fixed ts troubleshooting format issues * [docs/site] - added automatic operating system detection * [x/ts] - added lowercase OS detection * [docs/site] - tuned link appearances in release notes * [docs/site] - fixed margins on pluto text * [docs/site] - fixed spacing in release note title * [docs/site] - fixed control examples * [docs/site] - added missing divider to release notes * thruster and strainers * final touches * [client/py] - improved documentation for press sequence * adding connections + small fixes" * [docs/site] - fixed issues with rules of writes documentation * formatting * vacuum pump is back baby * unnecessary import * updating vacuum pump (general compressor) to match other compressors * vacuum pump and compressor are now the same thing --------- Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com> * [ops] - bumped platform version * Auto Update JSON File * remove an underscore * fix range view details ontology context menu * Auto Update JSON File * Add Group Item To Visualization Ontology Context Menus (#1025) * Auto Update JSON File * [pluto] - various minor tweaks to flowmeters and symbol handle positioning (#1019) * [pluto] - fixed text box preview alignment (#1020) * [pluto] - fixed meta data link highlight (#1021) * [console] - fixed out of order hooks in schematic toolbar (#1024) * [pluto] - removed focus trapping (#1026) * Auto Update JSON File * Sy 1771 bad ontology relationship created on grouped device (#1022) * [synnax] - improved device service tests * [synnax] - changed device service group method name * [pluto] - fixed issues with bad box shadows under different themes (#1028) * Edit QA steps for ontology context menus (#1029) * Auto Update JSON File * Fix Channel List on NI Digital Write Task (#1027) * Auto Update JSON File * SY-1787 Prevent Snapshot of Schematics from Toolbar Outside of Workspace (#1023) * Change Hotkeys (#1031) * Auto Update JSON File * [pluto] - fixed input onChange handler firing on empty strings (#1030) * Auto Update JSON File * [pluto] - fixed issues with bad writer commit on control release for … (#1032) * [pluto] - fixed issues with bad writer commit on control release for the console schematic * [pluto/telem/control] - improved docs in control acquire * Sy 1805 fix setpoint over activating (#1033) * [pluto] - fixed issue where set point would activate without user clicking button * [pluto] - fixed merged conflicts * [docs/site] - version 37 release notes (#1018) * [docs/site] - version 37 release notes * Fix typos and change wording --------- Co-authored-by: pjdotson <patrick@synnaxlabs.com> * Auto Update JSON File * [docs/site] - fixed release notes background * SY-1796: Revert Agitator Primitives (#1034) * Auto Update JSON File * Remove Range Snapshot from Schematic Toolbar (#1035) * Auto Update JSON File * [pluto/mosaic] - fixed file drag and drop on windows (#1037) * Sy 1800 lower contrast threshold to trigger schematic color change (#1036) * [pluto] - implemented grayness * [console] - improved contrast and grayness threshold checks for schematic color changes * [pluto] - updated grayness calculation algorithm * Auto Update JSON File * [pluto] - fixed connection points on cross junction * Auto Update JSON File * [driver/opc] use scalarcopy instead of set scalar (#1038) --------- Co-authored-by: pjdotson <patrick@synnaxlabs.com> Co-authored-by: Patrick Dotson <123601024+pjdotson@users.noreply.github.com> Co-authored-by: pjdotson <pjdotson@users.noreply.github.com> Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com> Co-authored-by: emilbon99 <emilbon99@users.noreply.github.com> Co-authored-by: evanhekman <145033487+evanhekman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Pull Request
Key Information
Description
Fixed an issue where the setpoint component would fire even if the button was not clicked.
Basic Readiness
Backwards Compatibility
Data Structures
I have ensured that previous versions of stored data structures are properly migrated to new formats in the following projects:
API Changes
The following projects have backwards-compatible APIs:
Breaking Changes