[flexible-schema] Add reserved keyword check on object creation (twen…

…tyhq#5303) ## Context Because creating an object in metadata also generates a graphql type and because graphql does not allow 2 types with the same name, we have to manage a list of reserved keywords that can't be used as object names. Currently we were maintaining a list of the core objects but we also have to introduce composite fields that are also generated as gql types.
synapsenet-arena · May 6, 2024 · 154ae99 · 154ae99
1 parent 2828492
commit 154ae99
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/...server/src/engine/metadata-modules/object-metadata/hooks/before-create-one-object.hook.ts b/...server/src/engine/metadata-modules/object-metadata/hooks/before-create-one-object.hook.ts
@@ -12,12 +12,24 @@ import {
 import { CreateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/create-object.input';
 
 const coreObjectNames = [
-  'featureFlag',
   'appToken',
-  'workspace',
+  'billingSubscription',
+  'billingSubscriptionItem',
+  'featureFlag',
   'user',
+  'userWorkspace',
+  'workspace',
+];
+
+const reservedKeywords = [
+  ...coreObjectNames,
   'event',
   'field',
+  'link',
+  'currency',
+  'fullName',
+  'address',
+  'links',
 ];
 
 @Injectable()
@@ -35,8 +47,8 @@ export class BeforeCreateOneObject<T extends CreateObjectInput>
     }
 
     if (
-      coreObjectNames.includes(instance.input.nameSingular) ||
-      coreObjectNames.includes(instance.input.namePlural)
+      reservedKeywords.includes(instance.input.nameSingular) ||
+      reservedKeywords.includes(instance.input.namePlural)
     ) {
       throw new ForbiddenException(
         'You cannot create an object with this name.',