Please don't create directories with spaces in the filename (it's really annoying on Linux). :) OSXPackage is a good enough name, though.

Also, git is complaining about the lack of an ending newline in the .xml files, unless it's a problem to have them there (I don't know the format you're going for), then just put them so shut git up. :) (if they were autogenerated or something, leave them be I guess).

Can't really comment on the content, though, I don't use Mac. Lets wait for @asmeurer to ok it (he's the only one on Mac as far as I know).

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY-pcFDA

Note A custom interpreter was used: python2.5

Summary: All tests have passed.

Automatic review by sympy-bot.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYkJAFDA

Note A custom interpreter was used: python3

Summary: There were test failures.

@mattrajca: Please fix the test failures.

Automatic review by sympy-bot.

Don't worry about the Python 3 errors, they are unrelated (obviously).

On Thu, Nov 24, 2011 at 9:35 AM, Aaron Meurer
reply@reply.github.com
wrote:

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYkJAFDA

Note A custom interpreter was used: python3

Summary: There were test failures.

@mattrajca: Please fix the test failures.

Automatic review by sympy-bot.

---

Reply to this email directly or view it on GitHub:
#748 (comment)

Vladimir Perić

I updated the directory name. And those XML files were auto generated... Do you need me to do anything else?

If Aaron can test this, it can go in. I really can't as I've no Mac available.

And those XML files were auto generated...

Auto generated from what? We should put in something that will generate the XML files, not the generated files.

The problem is that, as you can see, the files reference the files on your specific system.

Anyway, this doesn't sem to work. I can create the installer, but the installation itself doesn't seem to work (if it does, I can't really tell where it's installing to).

For the last 3 days there was no activity on this, should we close it and reopen the task?
http://www.google-melange.com/gci/task/view/google/gci2011/7131305

Actually it's 4 days already. The student has not responded here or on melange. The deadline has passed but because it was marked as 'ready for review' the task was not automatically reopened. I'm reopening the task. If the student wishes he can of course reapply and he will be accepted. He could even reopen this pull request.

No need to close the pull request, though. We generally only do that if there hasn't been any work for a really long time (and even then, always make sure it is referenced in some issue somewhere, so that we can find it again).

Ok, thanks for the remark.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY78MGDA

Interpreter: /usr/bin/python (2.7.1-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 928c02d
branch hash: 029a046
XPassed tests: 2

Summary: All tests have passed.

Automatic review by sympy-bot.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYnLQGDA

Interpreter: /usr/bin/python (3.2.0-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 928c02d
branch hash: 029a046
XPassed tests: 2

Summary: All tests have passed.

Automatic review by sympy-bot.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY45kHDA

Interpreter: /usr/bin/python (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 928c02d
branch hash: 029a046
XPassed tests: 2

Summary: All tests have passed.

Automatic review by sympy-bot.

Should this actually be merged. It seems there were some problems (see the comments).

I don't think this should be merged, it doesn't even work for Aaron.

That's why I'm asking. If you were answering by mail and couldn't check, it actually got merged 2 days ago.

Actually, I am looking at it, I think @smichr just closed the pull request, without merging it in. I also can't seem to find it in my history, so I guess it wasn't merged.

I closed it about two days ago; I left and issue so it wouldn't be
lost. I didn't merge it.