Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrals.transforms: Fix for issue 2486 #2498

Merged
merged 3 commits into from
Nov 7, 2013
Merged

Conversation

hargup
Copy link
Contributor

@hargup hargup commented Oct 3, 2013

This tries to fix issue 2486.

#2486

@hargup
Copy link
Contributor Author

hargup commented Oct 3, 2013

@asmeurer The Travis CI build failed while running doctests on PyPy. Can you tell me how to fix it?

@asmeurer
Copy link
Member

asmeurer commented Oct 4, 2013

Ignore the Travis builds on PyPy (that's why they're in the "allowed failures" section). They won't pass until Travis updates their version of PyPy (travis-ci/travis-ci#1106).

@jrioux
Copy link
Member

jrioux commented Oct 27, 2013

Please add a test.

@hargup
Copy link
Contributor Author

hargup commented Oct 28, 2013

Hope this works fine.

@@ -547,6 +547,8 @@ def simp_hyp(expr):
assert ILT(1/(s*sqrt(s + 1)), s, t) == Heaviside(t)*erf(sqrt(t))
# TODO can we make erf(t) work?

assert ILT(1/(s**2*(s**2 + 1)),s,t) == (t - sin(t))*Heaviside(t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a trailing whitespace character on this line.

@jrioux
Copy link
Member

jrioux commented Oct 28, 2013

@asmeurer

try:
h = hyperexpand(G)
except NotImplementedError as detail:
raise IntegralTransformError(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this causes it to create an unevaluated object when it can't do it.

@asmeurer
Copy link
Member

asmeurer commented Nov 5, 2013

Looks OK to me.

@hargup
Copy link
Contributor Author

hargup commented Nov 7, 2013

I found that to compute inverse_laplace_transform sympy first tries to do the inverse_mellin_transform and then if it fails it the inversion integral. So, it doesn't always return an unevaluated object. In the particular cases added in the tests, sympy successfully solves the transform using the inversion integral after failing with inverse_mellin_transform .

@asmeurer
Copy link
Member

asmeurer commented Nov 7, 2013

OK, well that will need to be fixed eventually as well.

asmeurer added a commit that referenced this pull request Nov 7, 2013
integrals.transforms: Fix for issue 2486
@asmeurer asmeurer merged commit d49f5c0 into sympy:master Nov 7, 2013
@hargup hargup deleted the issue2486 branch November 8, 2013 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants