Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for lambdify with mpmath: powm1, log1p, expm1 #24323

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Add test for lambdify with mpmath: powm1, log1p, expm1 #24323

merged 2 commits into from
Nov 29, 2022

Conversation

bjodah
Copy link
Member

@bjodah bjodah commented Nov 28, 2022

References to other Issues or PRs

Follow up of #24300

Brief description of what is fixed or changed

  • Fix pessimization in MpMathPrinter

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

✅

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Follow up of #24300

#### Brief description of what is fixed or changed
- Fix pessimization in MpMathPrinter

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)



Significantly changed benchmark results (master vs previous release)


       before           after         ratio
     [41d90958]       [cdef6fcb]
     <sympy-1.11.1^0>                 
-     1.11±0.05ms         707±60μs     0.64  solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
-     3.01±0.04ms      1.33±0.08ms     0.44  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-      5.99±0.1ms      1.91±0.07ms     0.32  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)



Full benchmark results can be found as artifacts in GitHub Actions

(click on checks at the top of the PR).

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            







      

  
      



  

  @oscarbenjamin





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        


  
    

      
          
Looks good.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  

  



        @oscarbenjamin
  oscarbenjamin



        merged commit d254c83
      into

      
  
    sympy:master
  


    Nov 29, 2022

  
















  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    

    No reviews






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    printing

  

    utilities.lambdify









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @bjodah 
        
          @sympy-bot 
        
          @oscarbenjamin