-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of warnings from the test suite #23754
Cleanup of warnings from the test suite #23754
Conversation
✅ Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[77f1d79c] [cace0875]
<sympy-1.10.1^0>
+ 97.9±0.4ms 179±1ms 1.83 sum.TimeSum.time_doit
Full benchmark results can be found as artifacts in GitHub Actions |
sympy/printing/aesaracode.py
Outdated
@@ -139,7 +139,7 @@ def _get_or_create(self, s, name=None, dtype=None, broadcastable=None): | |||
if key in self.cache: | |||
return self.cache[key] | |||
|
|||
value = aet.tensor(name=name, dtype=dtype, broadcastable=broadcastable) | |||
value = aet.tensor(name=name, dtype=dtype, shape=broadcastable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is incompatible with Theano: #23745 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted this change. We will need to consider separately how easy it will be to support both Theano and Aesara going forwards. At some point it definitely makes sense to just drop support for Theano.
This was changed because Aesara gives a warning when the broadcastable argument is used and suggests changing it to shape. However shape is incompatible with Theano so this commit restores the use of the broadcastable argument that works with both Theano and Aesara although it gives a warning under Aesara.
This is ready for review. |
Thanks! |
References to other Issues or PRs
Brief description of what is fixed or changed
Various fixes related to things that give warnings in the test suite (including some warnings that are hidden by default):
with open()
)communicate
etc)imp
modulenp.matrix
typeAlso:
broadcastable
argument in favour ofshape
.language_level=3
in the generated cython code.Other comments
I would like to merge this as a bunch of minor fixes and then rebase #23745 and think more generally about how to handle warnings in CI.
Release Notes
language_level = 3
in the generated Cython code.