-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved type checking #22135
Improved type checking #22135
Conversation
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
2ac6fa7
to
2ca0878
Compare
2ca0878
to
7431cfd
Compare
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) Full benchmark results can be found as artifacts in GitHub Actions |
Is this finished? |
I'd say so. I have not changed absolutely every used of |
at least many... |
References to other Issues or PRs
Brief description of what is fixed or changed
Improved type checking, either by using
isinstance
or merging severalisinstance
checks.Other comments
There are still some instances remaining. Also, I'm not sure if code of the type
if type(a) == type(b):
is better off asif isinstance(a, type(b)):
?Release Notes
NO ENTRY