Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved type checking #22135

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Improved type checking #22135

merged 1 commit into from
Sep 22, 2021

Conversation

oscargus
Copy link
Contributor

References to other Issues or PRs

Brief description of what is fixed or changed

Improved type checking, either by using isinstance or merging several isinstance checks.

Other comments

There are still some instances remaining. Also, I'm not sure if code of the type if type(a) == type(b): is better off as if isinstance(a, type(b)):?

Release Notes

NO ENTRY

@sympy-bot
Copy link

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Improved type checking, either by using `isinstance` or merging several `isinstance` checks.

#### Other comments
There are still some instances remaining. Also, I'm not sure if code of the type `if type(a) == type(b):` is better off as `if isinstance(a, type(b)):`?

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@oscargus oscargus force-pushed the bettertypechecking branch 2 times, most recently from 2ac6fa7 to 2ca0878 Compare September 22, 2021 18:35
@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin
Copy link
Collaborator

Is this finished?

@oscargus
Copy link
Contributor Author

Is this finished?

I'd say so. I have not changed absolutely every used of type, but most and also trying to limit the number of file changed per PR...

@oscargus
Copy link
Contributor Author

most

at least many...

@smichr smichr merged commit c4bcd75 into sympy:master Sep 22, 2021
@oscargus oscargus deleted the bettertypechecking branch September 23, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants