Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3223:degree((x+1)**10000) takes too long #1793

Closed
wants to merge 3 commits into from
Closed

Issue 3223:degree((x+1)**10000) takes too long #1793

wants to merge 3 commits into from

Conversation

hargup
Copy link
Contributor

@hargup hargup commented Feb 16, 2013

https://code.google.com/p/sympy/issues/detail?id=3223
sympy.polys.polytools.degree(f, _gens, *_args) rewritten in the way described in the thread.

@jrioux
Copy link
Member

jrioux commented Feb 16, 2013

SymPy Bot Summary: 🔴 Failed after merging hargup/master (7fee1c0) into master (6dde28a).
@hargup: Please fix the test failures.
🔴 PyPy 2.0.0-beta-1; 2.7.3-final-42: fail
🔴 Python 2.7.2-final-0: fail
🔴 Python 3.2.1-final-0: fail
✳️ Sphinx 1.1.3: pass
Docs build command: make clean && make html-errors && make latex && cd _build/latex && xelatex sympy-*.tex

@jrioux jrioux mentioned this pull request Feb 21, 2013
Merged
@jrioux
Copy link
Member

jrioux commented Feb 21, 2013

SymPy Bot Summary: ✳️ Passed after merging hargup/master (0308061) into master (bb44ac7).
✳️ Sphinx 1.1.3: pass
Docs build command: make clean && make html-errors && make latex && cd _build/latex && xelatex sympy-*.tex

@jrioux jrioux mentioned this pull request Feb 21, 2013
Merged
jrioux added a commit to sympy/sympy-bot-old that referenced this pull request Feb 22, 2013
@jrioux
Merge pull request #148 from jrioux/reviews
bf4cf8e 
Handle cleanly the case when pull["head"]["repo"] returns None.

This may be linked to the user sending a PR from his master branch.
For example, see sympy/sympy#1793
@jrioux
Copy link
Member

jrioux commented Feb 24, 2013

SymPy Bot Summary: ✳️ Passed after merging hargup/master (0308061) into master (6b17d5a).
✳️ PyPy 2.0.0-beta-1; 2.7.3-final-42: pass
✳️ Python 2.7.2-final-0: pass
✳️ Python 3.2.1-final-0: pass
✳️ Sphinx 1.1.3: pass
Docs build command: make clean && make html-errors && make latex && cd _build/latex && xelatex sympy-*.tex

smichr
smichr reviewed Feb 24, 2013
View reviewed changes
sympy/polys/polytools.py
pass

if f is polynomial:
if len(f.free_symbols) is 1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a space at the end of L3969 that needs to be deleted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff shown by github is misleading. If you inspect hargup's master branch carefully, it looks like he has rebased these commits out.

@jrioux
Copy link
Member

jrioux commented Feb 25, 2013

Closing in favour of #1801.

@jrioux jrioux closed this Feb 25, 2013
@asmeurer
Copy link
Member

asmeurer commented Mar 1, 2013

SymPy Bot Summary: ✳️ Passed after merging hargup/master (0308061) into master (d097851).
✳️ Python 2.5.6-final-0: pass
✳️ Python 2.6.8-final-0: pass
✳️ Python 2.7.3-final-0: pass
✳️ Python 3.2.3-final-0: pass
✳️ Sphinx 1.1.3: pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hargup @jrioux @asmeurer @smichr