Correct function def of gray_to_bin and bin_to_gray #14468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smichr
reviewed
Mar 10, 2018
sympy/combinatorics/graycode.py
Outdated
| >>> from sympy.combinatorics.graycode import gray_to_bin | ||
| >>> gray_to_bin('100') | ||
| '111' | ||
|
|
||
| example taken from issue #117 from:- https://github.com/sympy/sympy-live/issues/117 |
There was a problem hiding this comment.
The test_graycode file would be a good place for this.
def test_live_issue_117():
assert bin_to_gray('0100') == '0110'
assert bin_to_gray('0101') == '0111'
for bits in ('0100', '0101'):
assert gray_to_bin(bin_to_gray(bits)) == bitsThese were confirmed with online calculator.
Note: in one test you spelled gray as gtay.
There was a problem hiding this comment.
Thanks for reviewing.
& sorry for that typo.
There was a problem hiding this comment.
You don't need to put a reference to the issue in the docstring. Putting it in the commit message is sufficient for provenance.
Examples are included in the test suite.
Add newline. Note: doctests taken from issue at sympy/sympy-live#117
|
There were some PEP8 issues that I corrected: a line with space and a file with no newline at the end. I also removed the docstring tests that were essentially duplicated in the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
This is my first commit to sympy.
I corrected definition of two functions named bin_to_gray and gray_to_bin.
There is an issue #117 in sympy-live repo but I checked same was because of sympy, so I send PR here.
I have tested with some examples.