[Validator] Fixed StaticMethodLoader does not try to invoke methods of abstract classes anymore #8592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Jul 27, 2013
fabpot
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #8589 |
| License | MIT |
| Doc PR | n/a |
|
|
||
| $loader->loadClassMetadata($metadata); | ||
|
|
||
| $this->assertSame(0, count($metadata->getConstraints())); |
There was a problem hiding this comment.
Tests are failing with:
PHPUnit_Framework_Exception: PHP Strict Standards:
Static function Symfony\Component\Validator\Tests\Mapping\Loader\AbstractStaticLoader::loadMetadata()
should not be abstract in
/home/travis/build/symfony/symfony/src/Symfony/Component/Validator/Tests/Mapping/Loader/StaticMethodLoaderTest.php on line 87
Looks like from this example's perspective the loadMetadata() method doesn't have to be abstract (could be empty for example). It should be sufficient if the class was abstract
…ract classes (closes symfony#8589)
fabpot
added a commit
that referenced
this pull request
Jul 28, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [Validator] Fixed StaticMethodLoader does not try to invoke methods of abstract classes anymore | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8589 | License | MIT | Doc PR | n/a Commits ------- b41cf82 [Validator] fixed StaticMethodLoader trying to invoke methods of abstract classes (closes #8589)
fabpot
added a commit
that referenced
this pull request
Aug 13, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [Validator] Fixed the wrong isAbstract() call in PR #8592 | Q | A | ------------- | --- | Bug fix? | [yes] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | Fixed tickets | [#8589] | License | MIT | Doc PR | [n/a] Commits ------- 18896d5a [Validator] fixed the wrong isAbstract() check against the class (fixed #8589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.