-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Process] Fix the command -v
exception
#54006
Merged
nicolas-grekas
merged 1 commit into
symfony:6.4
from
kayw-geek:bugfix/fix-command-hyphen-v-exception
Feb 20, 2024
Merged
[Process] Fix the command -v
exception
#54006
nicolas-grekas
merged 1 commit into
symfony:6.4
from
kayw-geek:bugfix/fix-command-hyphen-v-exception
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "5.4". Cheers! Carsonbot |
@nicolas-grekas Do you have time to help review? |
carsonbot
changed the title
Fix the
[Process] Fix the Feb 20, 2024
command -v
exception command -v
exception
nicolas-grekas
requested review from
xabbuh,
lyrixx,
dunglas,
yceruto,
welcoMattic,
kbond,
chalasr,
OskarStark and
jderusse
as code owners
February 20, 2024 12:31
nicolas-grekas
force-pushed
the
bugfix/fix-command-hyphen-v-exception
branch
from
February 20, 2024 12:31
851f2f0
to
2b73f0c
Compare
Thank you @kayw-geek. |
github-merge-queue bot
pushed a commit
to Lendable/composer-license-checker
that referenced
this pull request
Mar 2, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [symfony/console](https://symfony.com) ([source](https://togithub.com/symfony/console)) | `6.4.4` -> `7.0.4` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fconsole/7.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fconsole/7.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fconsole/6.4.4/7.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fconsole/6.4.4/7.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [symfony/process](https://symfony.com) ([source](https://togithub.com/symfony/process)) | `6.4.4` -> `7.0.4` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fprocess/7.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fprocess/7.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fprocess/6.4.4/7.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fprocess/6.4.4/7.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>symfony/console (symfony/console)</summary> ### [`v7.0.4`](https://togithub.com/symfony/console/releases/tag/v7.0.4) [Compare Source](https://togithub.com/symfony/console/compare/v7.0.3...v7.0.4) **Changelog** (symfony/console@v7.0.3...v7.0.4) - bug [symfony/symfony#54009](https://togithub.com/symfony/symfony/issues/54009) \[Console] Fix display of vertical Table on Windows OS ([@​VincentLanglet](https://togithub.com/VincentLanglet)) - bug [symfony/symfony#54001](https://togithub.com/symfony/symfony/issues/54001) \[Console] Fix display of Table on Windows OS ([@​VincentLanglet](https://togithub.com/VincentLanglet)) - bug [symfony/symfony#53707](https://togithub.com/symfony/symfony/issues/53707) \[Console] Fix color support for TTY output ([@​theofidry](https://togithub.com/theofidry)) - bug [symfony/symfony#53711](https://togithub.com/symfony/symfony/issues/53711) \[Console] Allow false as a $shortcut in InputOption ([@​jayminsilicon](https://togithub.com/jayminsilicon)) ### [`v7.0.3`](https://togithub.com/symfony/console/releases/tag/v7.0.3) [Compare Source](https://togithub.com/symfony/console/compare/v7.0.2...v7.0.3) **Changelog** (symfony/console@v7.0.2...v7.0.3) - bug [symfony/symfony#53516](https://togithub.com/symfony/symfony/issues/53516) \[Console] Allow '0' as a $shortcut in InputOption.php ([@​lawsonjl-ornl](https://togithub.com/lawsonjl-ornl)) - bug [symfony/symfony#53576](https://togithub.com/symfony/symfony/issues/53576) \[Console] Only execute additional checks for color support if the output ([@​theofidry](https://togithub.com/theofidry)) ### [`v7.0.2`](https://togithub.com/symfony/console/releases/tag/v7.0.2) [Compare Source](https://togithub.com/symfony/console/compare/v7.0.1...v7.0.2) **Changelog** (symfony/console@v7.0.1...v7.0.2) - bug [symfony/symfony#52940](https://togithub.com/symfony/symfony/issues/52940) \[Console] Fix color support check on non-Windows platforms ([@​theofidry](https://togithub.com/theofidry)) - bug [symfony/symfony#52941](https://togithub.com/symfony/symfony/issues/52941) \[Console] Fix xterm detection ([@​theofidry](https://togithub.com/theofidry)) ### [`v7.0.1`](https://togithub.com/symfony/console/releases/tag/v7.0.1) [Compare Source](https://togithub.com/symfony/console/compare/v7.0.0...v7.0.1) **Changelog** (symfony/console@v7.0.0...v7.0.1) - no significant changes ### [`v7.0.0`](https://togithub.com/symfony/console/releases/tag/v7.0.0) [Compare Source](https://togithub.com/symfony/console/compare/v6.4.4...v7.0.0) **Changelog** (symfony/console@v7.0.0-RC2...v7.0.0) - no significant changes </details> <details> <summary>symfony/process (symfony/process)</summary> ### [`v7.0.4`](https://togithub.com/symfony/process/releases/tag/v7.0.4) [Compare Source](https://togithub.com/symfony/process/compare/v7.0.3...v7.0.4) **Changelog** (symfony/process@v7.0.3...v7.0.4) - bug [symfony/symfony#54006](https://togithub.com/symfony/symfony/issues/54006) \[Process] Fix the `command -v` exception (@​kayw-geek) - bug [symfony/symfony#53821](https://togithub.com/symfony/symfony/issues/53821) \[Process] Fix Inconsistent Exit Status in proc_get_status for PHP Versions Below 8.3 ([@​Luc45](https://togithub.com/Luc45)) ### [`v7.0.3`](https://togithub.com/symfony/process/releases/tag/v7.0.3) [Compare Source](https://togithub.com/symfony/process/compare/v7.0.2...v7.0.3) **Changelog** (symfony/process@v7.0.2...v7.0.3) - bug [symfony/symfony#53481](https://togithub.com/symfony/symfony/issues/53481) \[Process] Fix executable finder when the command starts with a dash ([@​kayw-geek](https://togithub.com/kayw-geek)) ### [`v7.0.2`](https://togithub.com/symfony/process/releases/tag/v7.0.2) [Compare Source](https://togithub.com/symfony/process/compare/v7.0.0...v7.0.2) **Changelog** (symfony/process@v7.0.1...v7.0.2) - bug [symfony/symfony#52864](https://togithub.com/symfony/symfony/issues/52864) \[HttpClient]\[Mailer]\[Process] always pass microseconds to usleep as integers ([@​xabbuh](https://togithub.com/xabbuh)) ### [`v7.0.0`](https://togithub.com/symfony/process/releases/tag/v7.0.0) [Compare Source](https://togithub.com/symfony/process/compare/v6.4.4...v7.0.0) **Changelog** (symfony/process@v7.0.0-RC2...v7.0.0) - no significant changes </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/composer-license-checker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the fixes made in PR #53481 to address the issue. The previous PR partially addressed the problem, but after further review and testing, it was determined that additional changes were needed.
Fix the
command -v
exception when the command option with a dash prefix.