[VarDumper] Fix dumping Twig source in stack traces #20326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 27, 2016
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20320 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
dump-fix
branch
from
f3f2a5a to
2226458
Compare
nicolas-grekas
force-pushed
the
dump-fix
branch
from
2226458 to
f16d44d
Compare
hhamon
reviewed
Oct 27, 2016
| { | ||
| parent::__construct($env); | ||
| if (null !== $env) { |
|
I've tested this PR and the new output is quite different from the one reported in #20320. However, I think that this new output makes it more difficult to understand what's going on (and there are some design issues, such as the different font families applied to the output):
|
|
@javiereguiluz please open a new issue or a PR (esp. for the font issue, which is not intentional) |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 27, 2016
…as-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Fix dumping Twig source in stack traces | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20320 | License | MIT | Doc PR | - Commits ------- f16d44d [VarDumper] Fix dumping Twig source in stack traces
This was referenced Nov 17, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.