-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm help "Cannot make side window the only window" on develop branch #1611
Comments
It happens because we force Helm to be always displayed at 0.4 frame height with |
@syl20bnr probably we should consider using |
@tuhdo how would that work in practice ? |
By advising it, we can disable display buffer alist for Helm help window and let it display fully, without closing the current active Helm window. We can safely set to the original display-buffer-alist (stored in spacemacs-display-buffer-alist), since the current Helm window won't be closed.
By advising it, we can disable display buffer alist for Helm help window and let it display fully, without closing the current active Helm window. We can safely set to the original display-buffer-alist (stored in spacemacs-display-buffer-alist), since the current Helm window won't be closed.
By advising it, we can disable display buffer alist for Helm help window and let it display fully, without closing the current active Helm window. We can safely set to the original display-buffer-alist (stored in spacemacs-display-buffer-alist), since the current Helm window won't be closed.
…er-alist When a Helm help buffer is detected, we don't treat it like other Helm buffers by simply adding its own entry in display-buffer-alist that does no additional action.
…er-alist When a Helm help buffer is detected, we don't treat it like other Helm buffers by simply adding its own entry in display-buffer-alist that does no additional action.
…er-alist When a Helm help buffer is detected, we don't treat it like other Helm buffers by simply adding its own entry in display-buffer-alist that does no additional action. Also simplify code: we don't need to backup and restore display-buffer-alist anymore. When popwin is enabled, it add its functions in display-buffer-alist and when disabled, it removes the functions. So, as long as we properly disable at Helm start and enable at Helm end, we have the same display-buffer-alist.
…er-alist When a Helm help buffer is detected, we don't treat it like other Helm buffers by simply adding its own entry in display-buffer-alist that does no additional action.
…er-alist When a Helm help buffer is detected, we don't treat it like other Helm buffers by simply adding its own entry in display-buffer-alist that does no additional action.
…er-alist When a Helm help buffer is detected, we don't treat it like other Helm buffers by simply adding its own entry in display-buffer-alist that does no additional action.
When a Helm help buffer is detected, we don't treat it like other Helm buffers by simply adding its own entry in display-buffer-alist that does no additional action.
@drmikehenry This issue is fixed in |
Thanks! This fixes the problem I was seeing. |
…er-alist When a Helm help buffer is detected, we don't treat it like other Helm buffers by simply adding its own entry in display-buffer-alist that does no additional action.
Is not it a plugin bug: jaypei/emacs-neotree#226 ? |
This issue still exists, pressing "SPC feR" again and again does not feel productive at all. |
Reinstall from develop branch fixed all errors with neotree and eshell buffer. |
I'm on spacemacs (master branch) and i think this has worked for me (and i think it should work with emacs too): (setq helm-split-window-inside-p t) |
Hi,
When I enter helm via
SPC b b
and try to bring up the help viaC-c ?
, I get the error message "Cannot make side window the only window". Help in helm works for me using the master branch; it's only on the develop branch I see this issue. Any ideas what's wrong? (This happens with no.spacemacs
customizations.)Thanks,
Michael Henry
The text was updated successfully, but these errors were encountered: