Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm help "Cannot make side window the only window" on develop branch #1611

Closed
drmikehenry opened this issue May 16, 2015 · 9 comments
Closed

Comments

@drmikehenry
Copy link

Hi,

When I enter helm via SPC b b and try to bring up the help via C-c ?, I get the error message "Cannot make side window the only window". Help in helm works for me using the master branch; it's only on the develop branch I see this issue. Any ideas what's wrong? (This happens with no .spacemacs customizations.)

Thanks,
Michael Henry

@tuhdo
Copy link
Contributor

tuhdo commented May 16, 2015

It happens because we force Helm to be always displayed at 0.4 frame height with display-buffer-alist, but the Helm help requires the Helm window to be full screen and the error happens for that reason.

@tuhdo
Copy link
Contributor

tuhdo commented May 16, 2015

@syl20bnr probably we should consider using window-purpose assign a purpose for a window to always display Helm buffers.

@syl20bnr
Copy link
Owner

@tuhdo how would that work in practice ?

tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 19, 2015
By advising it, we can disable display buffer alist for Helm help window
and let it display fully, without closing the current active Helm
window. We can safely set to the original display-buffer-alist (stored
in spacemacs-display-buffer-alist), since the current Helm window won't
be closed.
tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 19, 2015
By advising it, we can disable display buffer alist for Helm help window
and let it display fully, without closing the current active Helm
window. We can safely set to the original display-buffer-alist (stored
in spacemacs-display-buffer-alist), since the current Helm window won't
be closed.
tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 19, 2015
By advising it, we can disable display buffer alist for Helm help window
and let it display fully, without closing the current active Helm
window. We can safely set to the original display-buffer-alist (stored
in spacemacs-display-buffer-alist), since the current Helm window won't
be closed.
tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 19, 2015
…er-alist

When a Helm help buffer is detected, we don't treat it like other Helm
buffers by simply adding its own entry in display-buffer-alist that does
no additional action.
tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 19, 2015
…er-alist

When a Helm help buffer is detected, we don't treat it like other Helm
buffers by simply adding its own entry in display-buffer-alist that does
no additional action.
tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 20, 2015
…er-alist

When a Helm help buffer is detected, we don't treat it like other Helm
buffers by simply adding its own entry in display-buffer-alist that does
no additional action.

Also simplify code: we don't need to backup and restore
display-buffer-alist anymore. When popwin is enabled, it add its
functions in display-buffer-alist and when disabled, it removes the
functions. So, as long as we properly disable at Helm start and enable
at Helm end, we have the same display-buffer-alist.
tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 20, 2015
…er-alist

When a Helm help buffer is detected, we don't treat it like other Helm
buffers by simply adding its own entry in display-buffer-alist that does
no additional action.
tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 21, 2015
…er-alist

When a Helm help buffer is detected, we don't treat it like other Helm
buffers by simply adding its own entry in display-buffer-alist that does
no additional action.
tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue May 21, 2015
…er-alist

When a Helm help buffer is detected, we don't treat it like other Helm
buffers by simply adding its own entry in display-buffer-alist that does
no additional action.
syl20bnr pushed a commit that referenced this issue May 28, 2015
When a Helm help buffer is detected, we don't treat it like other Helm
buffers by simply adding its own entry in display-buffer-alist that does
no additional action.
@tuhdo
Copy link
Contributor

tuhdo commented May 28, 2015

@drmikehenry This issue is fixed in develop.

@drmikehenry
Copy link
Author

Thanks! This fixes the problem I was seeing.

kryptt pushed a commit to kryptt/spacemacs that referenced this issue Sep 6, 2015
…er-alist

When a Helm help buffer is detected, we don't treat it like other Helm
buffers by simply adding its own entry in display-buffer-alist that does
no additional action.
@bapcyk
Copy link

bapcyk commented Nov 3, 2017

Is not it a plugin bug: jaypei/emacs-neotree#226 ?

@ghost
Copy link

ghost commented Dec 22, 2017

This issue still exists, pressing "SPC feR" again and again does not feel productive at all.

@ghost
Copy link

ghost commented Dec 22, 2017

Reinstall from develop branch fixed all errors with neotree and eshell buffer.

@unalterable
Copy link

I'm on spacemacs (master branch) and i think this has worked for me (and i think it should work with emacs too):

(setq helm-split-window-inside-p t)
I put it in my user -config() (which is a set of commands run after spacemacs loads all its layers/packages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants