Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor manager message box #4403

Merged
merged 11 commits into from
Sep 14, 2021
Merged

Refactor manager message box #4403

merged 11 commits into from
Sep 14, 2021

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented Sep 11, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #4403 (11abc9e) into master (9dbff4c) will increase coverage by 1.12%.
The diff coverage is 65.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4403      +/-   ##
==========================================
+ Coverage   51.42%   52.55%   +1.12%     
==========================================
  Files          73       73              
  Lines       14691    14797     +106     
==========================================
+ Hits         7555     7776     +221     
+ Misses       7136     7021     -115     
Impacted Files Coverage Δ
src/reactor/epoll.cc 75.23% <ø> (ø)
src/wrapper/event.cc 88.88% <0.00%> (-1.50%) ⬇️
src/server/manager.cc 38.35% <49.25%> (+7.47%) ⬆️
src/os/process_pool.cc 58.24% <57.50%> (+0.34%) ⬆️
src/server/reactor_thread.cc 57.60% <72.72%> (-0.17%) ⬇️
src/server/master.cc 58.69% <82.60%> (+3.90%) ⬆️
src/reactor/base.cc 81.16% <100.00%> (+0.43%) ⬆️
src/server/reactor_process.cc 56.43% <100.00%> (+16.43%) ⬆️
src/server/task_worker.cc 44.54% <100.00%> (+22.37%) ⬆️
src/server/worker.cc 54.22% <100.00%> (+0.73%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbff4c...11abc9e. Read the comment docs.

@matyhtf matyhtf merged commit e6b0cb6 into master Sep 14, 2021
@matyhtf matyhtf deleted the refactor-manager-message-box branch September 14, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant