ffmpeginterface: Fix subtitles under windows #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @jcabrerav |
lfdominguez
approved these changes
Jun 17, 2020
|
Your commits must be signed to allow merge |
|
@lfdominguez But they are, no ? |
|
@lfdominguez ping |
|
ping @lfdominguez |
|
|
Oh, is the gpg signature and not normal signatures, thanks ! |
There is a problem related to relative and global paths with subtitles in ffmpeg. For more information, check: https://trac.ffmpeg.org/ticket/3334 Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
fix_windows_subtitles
branch
from
ee63cae to
8edb3f2
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem related to relative and global paths with
subtitles in ffmpeg.
For more information, check: https://trac.ffmpeg.org/ticket/3334
Signed-off-by: Patrick José Pereira patrickelectric@gmail.com