Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parallel building #54

Merged
merged 4 commits into from
Aug 15, 2018
Merged

fix parallel building #54

merged 4 commits into from
Aug 15, 2018

Conversation

ThatNerdyPikachu
Copy link
Contributor

No description provided.

@ThatNerdyPikachu ThatNerdyPikachu mentioned this pull request Aug 13, 2018
Closed
@WinterMute
Copy link
Collaborator

Also needs https://github.com/switchbrew/switch-examples/blob/master/templates/application/Makefile#L99-L102 and https://github.com/switchbrew/switch-examples/blob/master/templates/application/Makefile#L179

@ThatNerdyPikachu
Copy link
Contributor Author

Please tell me if I did it wrong, I suck at Makefiles

@WinterMute
Copy link
Collaborator

LGTM

yellows8
yellows8 reviewed Aug 13, 2018
View reviewed changes
Makefile.nx Outdated
@@ -188,6 +190,8 @@ $(OUTPUT).elf : $(OFILES)
@echo $(notdir $<)
@$(bin2o)

$(OFILES_SRC) : $(HFILES_BIN)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should've been after the "$(OUTPUT).elf : $(OFILES)" line.

@yellows8 yellows8 merged commit 8034053 into switchbrew:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yellows8 yellows8 yellows8 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThatNerdyPikachu @WinterMute @yellows8