Initial audio support #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fincs
reviewed
Feb 13, 2018
nx/include/switch/services/audout.h
Outdated
| } AudioOutState; | ||
|
|
||
| /// audio output buffer format | ||
| typedef struct AudioOutBuffer AudioOutBuffer; |
There was a problem hiding this comment.
I think the comment should be on the struct below, not the typedef; otherwise I think it will throw doxygen off.
There was a problem hiding this comment.
Ok. By the way, I based this on applet.h which appears to suffer from the same issue.
There was a problem hiding this comment.
Actually nvm, looks like doxygen can handle it.
fincs
reviewed
Feb 13, 2018
nx/source/services/audout.c
Outdated
| AudioOutState State = 0; | ||
|
|
||
| // Passing an empty device name will open the default "DeviceOut" | ||
| char DeviceNameIn[DEVICE_NAME_LENGTH]; |
There was a problem hiding this comment.
This is uninitialized... perhaps it should have = {0} at the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic audio output support via "audout:u" service.