HashAlgorithm conformance that wraps CryptoKit.SHA256 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
aciidgh
approved these changes
Jan 10, 2020
hartbit
force-pushed
the
crypto-sha256
branch
from
c21c165 to
6f61d33
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
hartbit
force-pushed
the
crypto-sha256
branch
from
6f61d33 to
dfed635
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
hartbit
force-pushed
the
crypto-sha256
branch
from
dfed635 to
d6e5647
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
hartbit
force-pushed
the
crypto-sha256
branch
from
d6e5647 to
a1391d6
Compare
|
@swift-ci please test |
|
@swift-ci test |
hartbit
force-pushed
the
crypto-sha256
branch
from
a1391d6 to
8193aec
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
hartbit
force-pushed
the
crypto-sha256
branch
from
8193aec to
3321050
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Comment on lines
184
to
187
| if #available(macOS 10.15, *) { | ||
| return bytes.withData { data in | ||
| let digest = CryptoKit.SHA256.hash(data: data) | ||
| return ByteString(digest) | ||
| } | ||
| } else { | ||
| fatalError("not supported on this platform") | ||
| } |
There was a problem hiding this comment.
I think this will need to use conditional compilation directives.
- if #available(macOS 10.15, *) {
+ #if canImport(CryptoKit)
return bytes.withData { data in
let digest = CryptoKit.SHA256.hash(data: data)
return ByteString(digest)
}
- } else {
+ #else
fatalError("not supported on this platform")
- }
+ #endifThere was a problem hiding this comment.
That resolves the Linux issue, but macOS still does not weak link the framework.
hartbit
force-pushed
the
crypto-sha256
branch
from
3321050 to
f34f419
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.