Respect SWIFT_TOOLCHAIN_MACOS_DEPLOYMENT_TARGET if it is set in the environment
#220
Conversation
abertelrud
requested review from
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
|
@swift-ci please test linux |
|
Looks like the same issue as in #218, which appears to be an infrastructure issue. @shahmishal |
|
@swift-ci please test linux |
|
leaking cc @artemcm |
Yes, I agree, and did this because SwiftDriver is already using but — but perhaps that was a bit hasty. We should change the one in SwiftDriver then as well, if we have a generic one, or set all three independently. We basically want to build the components of the toolchain with the minimum deployment target the toolchain supports, and ideally keep them the same. |
What would you think about having separate names and then having the toolchain build script set them all the same? That also provides independent control if it's needed. |
wither that or use a generic one like |
That would probably be better, especially as we extend this to other platforms that have deployment targets. @artemcm any preference? |
abertelrud
force-pushed
the
eng/anders/allow-newer-min-deployment-target
branch
from
b19825a to
9465032
Compare
…uring Swift toolchain build) If it is not set in the environment, stay with the default minimum deployment target of 10.10 on macOS. This aligns with both swift-package-manager and with swift-driver, and is important now that ToolSupportCore has started containing some code that is annotated with availability for Darwin platforms. It uses the more project-neutral name `SWIFT_TOOLCHAIN_MACOS_DEPLOYMENT_TARGET` and the expectation is that both SwiftPM and SwiftDriver will switch to using it as well.
abertelrud
force-pushed
the
eng/anders/allow-newer-min-deployment-target
branch
from
9465032 to
b333a2b
Compare
abertelrud
changed the title
SWIFTPM_MACOS_DEPLOYMENT_TARGET if it is set in the environmentSWIFT_TOOLCHAIN_MACOS_DEPLOYMENT_TARGET if it is set in the environment
|
@swift-ci please test |
…h as during Swift toolchain build) (#220) If it is not set in the environment, stay with the default minimum deployment target of 10.10 on macOS. This aligns with both swift-package-manager and with swift-driver, and is important now that ToolSupportCore has started containing some code that is annotated with availability for Darwin platforms. It uses the more project-neutral name `SWIFT_TOOLCHAIN_MACOS_DEPLOYMENT_TARGET` and the expectation is that both SwiftPM and SwiftDriver will switch to using it as well. (cherry picked from commit 21a7918)
…h as during Swift toolchain build) (#220) (#224) If it is not set in the environment, stay with the default minimum deployment target of 10.10 on macOS. This aligns with both swift-package-manager and with swift-driver, and is important now that ToolSupportCore has started containing some code that is annotated with availability for Darwin platforms. It uses the more project-neutral name `SWIFT_TOOLCHAIN_MACOS_DEPLOYMENT_TARGET` and the expectation is that both SwiftPM and SwiftDriver will switch to using it as well. (cherry picked from commit 21a7918)
Respect
SWIFT_TOOLCHAIN_MACOS_DEPLOYMENT_TARGETif it is set in the environment, otherwise stay with the default minimum deployment target of 10.10 on macOS.ToolsSupportCore has availability annotations to represent requirements on various versions of macOS. Yet ToolsSupportCore itself doesn't specify a minimum deployment target for macOS, and so it always builds for macOS 10.10.
This aligns with both swift-package-manager and with swift-driver, and is important now that ToolSupportCore has started containing some code that is annotated with availability for Darwin platforms (Netrc support required 10.13 or later). It does use the package-neutral name
SWIFT_TOOLCHAIN_MACOS_DEPLOYMENT_TARGETand the expectation is that both SwiftDriver and SwiftPM will at some point switch to that name as well.