Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky test that can hang in CI #205

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix flaky test that can hang in CI #205

merged 1 commit into from
Apr 7, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Apr 7, 2021 •
edited
Loading

motivation: stable CI

background:

  • testSignal can hang sometimes when the child processes it creates do not recieve the expeted signal.
  • this has been observed when waitForFile timed-out and the test exited before issuing the signal.
  • this behavior is unexpected and points to potential issue with xctest, but this fix attempts to workaround the underlying issue by making sure the sub-processes are forced-killed by the test itself

changes:

  • regsiter the sub-processes in a process-set and force temrinate them at the end of the test

rdar://74356445

@tomerd
fix flaky test that can hang in CI
d690425 
motivation: stable CI

background:
* testSignal can hang *sometimes* when the child processes it creates do not recieve the expeted signal.
* this has been observed when waitForFile timed-out and the test existed before issuing the signal.
* this behavior is unexpected and points to potential issue with xctest, but this fix attempts to workaround the underlying issue by making sure the sub-rocesses are forced-killed by the test itself

changes:
* regsiter the sub-processes in a process-set and force temrinate them at the end of the test

rdar://74356445
@tomerd
Copy link
Contributor Author

tomerd commented Apr 7, 2021

@swift-ci please test

abertelrud
abertelrud approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@tomerd tomerd merged commit 2e35c0a into swiftlang:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abertelrud abertelrud abertelrud approved these changes

@neonichu neonichu neonichu approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomerd @neonichu @abertelrud