Fix compiling for 32-bit ARM platforms #204
Conversation
finagolfin
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
thanks @buttaface this seems fine. one nit: looks like line alignment is not standard, could you please re-format with Xcode defaults (ctrl+i) |
|
I don't use Xcode, haven't had a mac in a dozen years, is there some other cross-platform tool like swift-format that does the same? |
|
Hi, looks good to me, I've also added the rest of the initialization in FD_SET/FD_ISSET and submitted a PR to your branch. |
yes. you can also use https://github.com/nicklockwood/SwiftFormat, and run it on the file you changes, e.g. |
|
Alright, reformatted and added @uraimo's other patch, let me know if there's anything else to tweak. |
|
@swift-ci test |
|
cc @drexin |
I came up with the Android portion of this pull when getting the Swift toolchain cross-compiled to run on Android armv7, then found later that @uraimo had patched it similarly earlier for linux armv7, as part of broader changes. I have only taken the analogous part to Android from his patch, as that's all I needed to successfully build. I don't think this feature works without further changes though, perhaps as he added.
@uraimo, could you sign off on upstreaming the non-Android part of this pull, which I got from your patch? If there's any other changes to this repo worth adding now, let me know.
@KittyMac, if you turned up any more patches in your recent linux armv7 work, let us know.