refactor ManifestResources into simpler ToolchainConfiguration #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
tomerd
force-pushed
the
refactor/toolchain-configuration
branch
5 times, most recently
from
2532415 to
1607349
Compare
|
@swift-ci please smoke test |
motivation: improve code readability, prep work for further api refactoring for configuration changes: * remove ManifestResources abstraction and impl into plain struct named ToolchainConfiguration * udpate test module to define defaults for ToolchainConfiguration and UserToolchain to simplify and clean code * update call-sites, tests
tomerd
force-pushed
the
refactor/toolchain-configuration
branch
from
1607349 to
15bbfe4
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
neonichu
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: improve code readability, prep work for further api refactoring for configuration
changes: