-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt swift-collections #3632
Merged
shahmishal
merged 3 commits into
main
from
revert-3628-revert-3595-refactor/swift-colections-2
Aug 18, 2021
Merged
adopt swift-collections #3632
shahmishal
merged 3 commits into
main
from
revert-3628-revert-3595-refactor/swift-colections-2
Aug 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holding on to this one until we understand CI linkage failures |
@swift-ci please smoke test |
depends on: swiftlang/swift-driver#773 (or alternative) and apple/swift-collections#64 |
@swift-ci please smoke test |
requires swiftlang/swift#38881 |
tomerd
added
ready
Author believes the PR is ready to be merged & any feedback has been addressed
and removed
DO NOT MERGE
labels
Aug 14, 2021
neonichu
approved these changes
Aug 16, 2021
abertelrud
approved these changes
Aug 17, 2021
shahmishal
deleted the
revert-3628-revert-3595-refactor/swift-colections-2
branch
August 18, 2021 15:20
shahmishal
pushed a commit
that referenced
this pull request
Aug 19, 2021
tomerd
added a commit
that referenced
this pull request
Aug 20, 2021
tomerd
added a commit
that referenced
this pull request
Sep 13, 2021
tomerd
added a commit
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brings back #3595