[Gardening] Add missing "clone TSC" step to bootstrap instructions and reformat existing steps #3598
Conversation
WowbaggersLiquidLunch
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
WowbaggersLiquidLunch
force-pushed
the
update-bootstrap-instructions
branch
from
6b88ce5 to
addb0e0
Compare
CONTRIBUTING.md
Outdated
| ``` | ||
| Clone the following repositories beside the SwiftPM directory: | ||
|
|
||
| 1. [swift-driver] |
There was a problem hiding this comment.
Perhaps it's just me, but I've always found it easier to think of these dependencies "from the bottom up", i.e. starting with those that don't have any other dependencies, and they working one's way up the layers. So it's a little odd to see swift-driver before swift-tools-support-core. So I would suggest going in dependency order, starting with those that don't have any dependencies and finishing with swift-package-manager.
There was a problem hiding this comment.
Yes this makes sense, and is also consistent with the order they're built in bootstrap. I ordered them "from the bottom up" in 2c7df48.
There was a problem hiding this comment.
finishing with
swift-package-manager
Cloning SwiftPM is already mentioned in line 19 so I didn't repeat it in the bootstrap instructions.
Also sorted, reformatted and updated versions of existing `git clone` steps.
WowbaggersLiquidLunch
force-pushed
the
update-bootstrap-instructions
branch
from
addb0e0 to
2c7df48
Compare
bootstrapneeds TSC, but it's missing from the instructions inCONTRIBUTING. This PR adds it.In addition, all
git clonesteps in the instructions are sorted alphabetically descending and with "straightforward" ones coming before those that need some more care. Versions for swift-argument-parser and swift-crypto are updated to the latest in this PR, so #3595 won't need to.This PR conflicts with #3595.