Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftDriver: speculative changes to support Windows macros #1433

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Sep 4, 2023

The test suite is currently entirely broken on Windows (awaiting @cachemeifyoucan to fix #1431). This speculatively changes the driver to alter the search paths to match swiftlang/swift#68322).

The test suite is currently entirely broken on Windows (awaiting
@cachemeifyoucan to fix swiftlang#1431).  This speculatively
changes the driver to alter the search paths to match
swiftlang/swift#68322).
@compnerd
Copy link
Member Author

compnerd commented Sep 4, 2023

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 5, 2023

@DougGregor would be nice to get this in to allow cherry-picking for the 5.9 release

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@compnerd compnerd merged commit 1444a8b into swiftlang:main Sep 6, 2023
3 checks passed
@compnerd compnerd deleted the virtual-paths branch September 6, 2023 00:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite broken on Windows due to CAS
2 participants