Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In WMO, make sure the dummy "primary" compilation input is a Swift source file #1350

Merged
merged 1 commit into from
May 3, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented May 2, 2023

Attempting to land #1346 again

Otherwise, if the first argument is anything else (e.g. an object file) we will use it as a key and the compiler won't be too happy about that.

Resolves rdar://108741675

@artemcm
Copy link
Contributor Author

artemcm commented May 2, 2023

@swift-ci test

…urce file

Otherwise, if the first argument is anything else (e.g. an object file) we will use it as a key and the compiler won't be too happy about that.

Resolves rdar://108741675
@artemcm artemcm force-pushed the OnlySourceForWMOSupplements-Again branch from db33f00 to 7bef081 Compare May 2, 2023 16:28
@artemcm
Copy link
Contributor Author

artemcm commented May 2, 2023

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented May 2, 2023

The original PR for this and #1347 got tested at the same time and passed testing; but, the change in #1347 wasn't quite right, which got exposed when this was merged. I've amended this change now to fix the logic error.
cc @etcwilde

@artemcm
Copy link
Contributor Author

artemcm commented May 2, 2023

@swift-ci test Windows platform

@artemcm artemcm merged commit 661d59f into swiftlang:main May 3, 2023
@artemcm artemcm deleted the OnlySourceForWMOSupplements-Again branch May 3, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants