[Sema] Emit dynamic actor isolation checks for derived protocol witnesses #78650
+133
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for `@preconcurrency` conformances If derived conformance is marked as `@preconcurrency` instead of marking synthesized members as `nonisolated` the compiler should insert dynamic checks.
…able protocol witnesses
|
@swift-ci please test |
AnthonyLatsis
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers Equatable, Hashable, and Codable derivations. RawRepresentable, Comparable are not applicable here because derivation is limited to enums.
The main chance here is to not inject
nonisolatedattribute when synthesizing witnesses for@preconcurrencyconformances during derivation, the compiler would make sure that they are used in correct isolation context by injecting dynamic action isolation checks.Resolves: rdar://142567811