build: adjust the early swift-driver handling #75965
Merged
+34
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
reviewed
Aug 19, 2024
compnerd
force-pushed
the
training-permit
branch
from
4339635 to
df0e6a0
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
compnerd
force-pushed
the
training-permit
branch
from
df0e6a0 to
304dbdd
Compare
|
@swift-ci please test Linux platform |
compnerd
force-pushed
the
training-permit
branch
from
304dbdd to
358fdac
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
training-permit
branch
from
358fdac to
9a36ac8
Compare
|
@swift-ci please test |
etcwilde
reviewed
Nov 8, 2024
compnerd
force-pushed
the
training-permit
branch
from
9a36ac8 to
4010a1e
Compare
|
@swift-ci please test |
artemcm
approved these changes
Nov 12, 2024
compnerd
force-pushed
the
training-permit
branch
from
4010a1e to
663f914
Compare
|
@swift-ci please test |
etcwilde
approved these changes
Nov 12, 2024
compnerd
force-pushed
the
training-permit
branch
from
663f914 to
a85c0cf
Compare
|
@swift-ci please test Linux platform |
Windows has a strict limit on the file path, and use of extended names for the build is not possible. Rather than hardcoding the location of the early swift-driver build, allow the user to specify the path. If the path is specified, we will attempt to copy `swift-driver` and `swift-help` from that location. Adjust the code to account for the build executable suffix. This should allow Windows to experiment with an early swift-driver build.
compnerd
force-pushed
the
training-permit
branch
from
a85c0cf to
cc27c83
Compare
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows has a strict limit on the file path, and use of extended names for the build is not possible. Rather than hardcoding the location of the early swift-driver build, allow the user to specify the path. If the path is specified, we will attempt to copy
swift-driverandswift-helpfrom that location. Adjust the code to account for the build executable suffix. This should allow Windows to experiment with an early swift-driver build.