Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIL: Use TinyPtrVector for the argument list in SILBasicBlock #35550

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

eeckstein
Copy link
Contributor

A TinyPtrVector is the right choice, because ~98% of blocks have 0 or 1 arguments.

This change also required to fix a header-file layering violation.

…nclude SILFunction.h

"Containers" should include their "content" and not the other way round.
Also, remove some unused stuff of SILArgument.
A TinyPtrVector is the right choice, because ~98% of blocks have 0 or 1 arguments.
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein eeckstein requested a review from atrick January 22, 2021 10:23
@eeckstein eeckstein merged commit 2c083ca into swiftlang:main Jan 22, 2021
@eeckstein eeckstein deleted the tinyptrvector-for-args branch January 22, 2021 11:50
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Should remove lots of allocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants