[Runtime] Mark swift_asprintf with __attribute__((__format__)) #35525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Jan 20, 2021
| Node->hasText() ? (int)Node->getText().size() : 0, \ | ||
| Node->hasText() ? Node->getText().data() : "", __VA_ARGS__) | ||
| TYPE_LOOKUP_ERROR_FMT( \ | ||
| "TypeDecoder.h:%d: Node kind %u \"%.*s\" - " Fmt, __LINE__, \ |
There was a problem hiding this comment.
%u for the line is probably better.
| Node->hasText() ? Node->getText().data() : "", __VA_ARGS__) | ||
| TYPE_LOOKUP_ERROR_FMT( \ | ||
| "TypeDecoder.h:%d: Node kind %u \"%.*s\" - " Fmt, __LINE__, \ | ||
| (int)Node->getKind(), Node->hasText() ? (int)Node->getText().size() : 0, \ |
There was a problem hiding this comment.
cast to unsigned please given that you are converting with %u.
This gives us build-time warnings about format string mistakes, like we would get if we called the built-in asprintf directly. Make TypeLookupError's format string constructor a macro instead so that its callers can get these build-time warnings. This reveals various mistakes in format strings and arguments in the runtime, which are now fixed. rdar://73417805
mikeash
force-pushed
the
swift_asprintf-static-checking
branch
from
2a00f03 to
216e555
Compare
|
@compnerd Thanks, fixed those. |
|
@swift-ci please test and merge |
|
@swift-ci please smoke test os x platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us build-time warnings about format string mistakes, like we would get if we called the built-in asprintf directly.
Wrap TypeLookupError format string creation in a macro that uses this to provide build-time warnings for its users as well.
This reveals various mistakes in format strings and arguments in the runtime, which are now fixed.
rdar://73417805