[Python] Fix 80 column violations #1598
Conversation
| // {run_directive_1} | ||
| // {run_directive_2} | ||
| // {run_directive_3} | ||
| // {run_directive_4} |
There was a problem hiding this comment.
I can't say that this part is an improvement...
There was a problem hiding this comment.
I agree. Could we make an exception to apply this rule for lit RUN directives?
There was a problem hiding this comment.
@gribozavr I totally agree - it is really really ugly :-)
Short of doing an ugly work around I think the best solution would be to simply skip linting of this file using the # flake8: noqa directive.
@modocache Can you think of a way to make it more fine grained? # noqa can be applied on a line basis, but I guess that would mess up RUN: parsing.
|
Looks fine to me, aside from @gribozavr's comments. I imagine this will be one of the more controversial lint rules, but I'm glad we will have a rule in place at all. |
|
@gribozavr @modocache Thanks for reviewing and thanks for good input. I've tried to address the issues identified by @gribozavr - please let me know if you find any additional things that needs fixing. As for the ugly work around in |
|
@practicalswift Thank you, I don't have further comments. |
…-in-python-code [Python] Fix 80 column violations
|
@practicalswift should works. OR, should also works. |
|
@rintaro Oh, I wasn't aware of that. Thanks a lot for noticing! 👍 I'll submit a PR fixing this right away :-) |
What's in this pull request?
Fix 80 column violations in the project's Python code.
Resolved bug number: –
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.