Require ThreadSafeBox.T to be Sendable
#1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
hamishknight
reviewed
Jun 3, 2024
hamishknight
approved these changes
Jun 3, 2024
| @@ -24,7 +24,7 @@ extension NSLock { | |||
| /// A thread safe container that contains a value of type `T`. | |||
| /// | |||
| /// - Note: Unchecked sendable conformance because value is guarded by a lock. | |||
| public class ThreadSafeBox<T>: @unchecked Sendable { | |||
There was a problem hiding this comment.
Out of curiosity, what issues are being caused by it not being Sendable?
There was a problem hiding this comment.
I think the main issue that I noticed was that some of the request handles in TestSourceKitLSPClient weren’t sendable. I didn’t technically hit any bug from it but I was wondering why I could modify local variables from the surrounding context from within the request handler, which generally isn’t safe.
ahoppen
force-pushed
the
thread-safe-box-sendable
branch
from
ccb571f to
2446ab4
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
thread-safe-box-sendable
branch
from
2446ab4 to
5b7d725
Compare
|
@swift-ci Please test |
hamishknight
reviewed
Jun 3, 2024
Otherwise, I think `ThreadSafeBox` might still have data races. This also requires us to make `TestSourceKitLSPClient.RequestHandler` sendable. rdar://128572489
ahoppen
force-pushed
the
thread-safe-box-sendable
branch
from
5b7d725 to
c7bf59e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, I think
ThreadSafeBoxmight still have data races. This also requires us to makeTestSourceKitLSPClient.RequestHandlersendable.rdar://128572489