Update APIGateway example to use AWSLambdaEvents #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabianfett looks good, but formatting issues. you can run the sanity script locally to see the error and fix it |
tomerd
reviewed
May 8, 2020
| let multiValueHeaders: [String: [String]]? | ||
| let body: String? | ||
| let isBase64Encoded: Bool? | ||
| } |
tomerd
reviewed
May 8, 2020
| @@ -30,13 +30,14 @@ let package = Package( | |||
| .product(name: "AWSLambdaRuntime", package: "swift-aws-lambda-runtime"), | |||
| ]), | |||
| .target(name: "Benchmark", dependencies: [ | |||
| .product(name: "AWSLambdaRuntime", package: "swift-aws-lambda-runtime"), | |||
| .product(name: "AWSLambdaRuntimeCore", package: "swift-aws-lambda-runtime"), | |||
|
@tomerd let me test this once on AWS before merging ;) |
fabianfett
force-pushed
the
update-apigateway-example-to-use-events
branch
from
2c99fd5
to
a3759f5
Compare
fabianfett
force-pushed
the
update-apigateway-example-to-use-events
branch
from
a3759f5
to
23b3971
Compare
|
@drexin Do you know whether we will get the static-stdlib linking in without the linker flags in |
tomerd
reviewed
May 12, 2020
| /usr/lib/swift/linux/libswiftCore.so \ | ||
| /usr/lib/swift/linux/libswiftDispatch.so \ | ||
| /usr/lib/swift/linux/libswiftGlibc.so \ | ||
| "$target" |
There was a problem hiding this comment.
@fabianfett can we rollback this one change for now? I would like to work on eliminating ICU for lambda then we can do a separate PR for that
tomerd
approved these changes
May 12, 2020
fabianfett
force-pushed
the
update-apigateway-example-to-use-events
branch
from
bf9e88b
to
9b61a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We now have an APIGateway request and response on board. Use it in the Sample.
Changes