Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #322] Fix reference links and upgrade to latest version of styles #323

Merged
merged 184 commits into from
Jul 13, 2020

Conversation

fmichonneau
Copy link
Contributor

I included here the syntax that should work best for internal links (resolving #322) and I'm bringing the latest version of styles at the same time as this repo hasn't gotten an update from styles in a while.

Sarah Brown and others added 30 commits June 1, 2018 02:52
_config.yml: no 'mailto' in 'email'
links.md: add links to carpentries' lessons overview pages
Check that Rmd episode files include `source: Rmd`

Fixes carpentries/styles#273
[fix carpentries/styles#311] update descriptions of the carpentries
added about the discussion stage to the LC description
Makefile: fix typo in clean-rmd rule
CODE_OF_CONDUCT.md is already at the root of the repository.
Fix lesson_initialize.py to initialize new lessons
space out callout elements better
fmichonneau and others added 24 commits December 13, 2019 12:21
Co-authored-by: Allen Lee <allen.lee@asu.edu>
* Makefile: improve commands target and commands categories

* replace 'files' with 'website'
Co-authored-by: Daniel McCloy <dan.mccloy@gmail.com>c
Co-authored-by: Sarah Brown <sarah_m_brown@brown.edu>
```
cd assets/js
wget https://code.jquery.com/jquery-3.5.1.min.js
wget https://code.jquery.com/jquery-3.5.1.min.map
mv -f jquery-3.5.1.min.js jquery.min.js
mv -f jquery-3.5.1.min.map jquery.min.map
```

Fixes carpentries/styles#460
.size() was deprecated in jQuery 3.0 in favor of .length attribute.
https://jquery.com/upgrade-guide/3.0/#breaking-change-deprecated-size-removed

Co-Authored-By: Thomas Green <tomgreen66@hotmail.com>
@henrykironde henrykironde merged commit 97c367b into gh-pages Jul 13, 2020
@henrykironde henrykironde deleted the fix-ref-links branch July 13, 2020 16:35
zkamvar pushed a commit that referenced this pull request May 8, 2023
[fix #322] Fix reference links and upgrade to latest version of styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.