Fix potentially confusing inconsistency in filtering challenge and solution #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consistent number - clarifies that this is about logic.
|
I think that is correct, it should be 48, Looks good to me. |
|
Thanks @dww100 in to goes. |
henrykironde
added a commit
to henrykironde/sql-novice-survey
that referenced
this pull request
Sep 19, 2019
- Add pictures to explain - use 42° instread of 48° This is a result of all the contributions and discussion from: @Denubis Brian Ballsun-Stanton <Denubis@users.noreply.github.com> @wtgee Wilfred Tyler Gee <wtylergee@gmail.com> @remram44 closes swcarpentry#292, swcarpentry#291 ref: swcarpentry#273 swcarpentry#214 and swcarpentry#278.
henrykironde
added a commit
to henrykironde/sql-novice-survey
that referenced
this pull request
Sep 19, 2019
- Add pictures to explain - use 42° instread of 48° This is a result of all the contributions and discussion from: @Denubis Brian Ballsun-Stanton <Denubis@users.noreply.github.com> @wtgee Wilfred Tyler Gee <wtylergee@gmail.com> @remram44 closes swcarpentry#292, swcarpentry#291 ref: swcarpentry#273 swcarpentry#214 and swcarpentry#278.
henrykironde
added a commit
to henrykironde/sql-novice-survey
that referenced
this pull request
Sep 19, 2019
- Add pictures to explain - use 42° instead of 48° From the contributions and discussions of: @Denubis Brian Ballsun-Stanton <Denubis@users.noreply.github.com> @wtgee Wilfred Tyler Gee <wtylergee@gmail.com> @remram44 closes swcarpentry#292, swcarpentry#291 ref: swcarpentry#273 swcarpentry#214 and swcarpentry#278.
henrykironde
added a commit
to henrykironde/sql-novice-survey
that referenced
this pull request
Sep 19, 2019
- Add pictures to explain - use 42° instead of 48° From the contributions and discussions of: @Denubis Brian Ballsun-Stanton <Denubis@users.noreply.github.com> @wtgee Wilfred Tyler Gee <wtylergee@gmail.com> @remram44 closes swcarpentry#292, swcarpentry#291 ref: swcarpentry#273 swcarpentry#214 and swcarpentry#278.
fmichonneau
pushed a commit
to fmichonneau/sql-novice-survey
that referenced
this pull request
Nov 1, 2019
Run lesson-fixme from within lesson-check
zkamvar
pushed a commit
that referenced
this pull request
May 8, 2023
Fix potentially confusing inconsistency in filtering challenge and solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The question asks the student to correct the following query such that it "selects all sites that lie more than 42 degrees from the poles":
SELECT * FROM Site WHERE (lat > -48) OR (lat < 48);The answer given changes the logic but leaves the queried value as 48. This seems like the right way to emphasise the error in query logic. I've edited the question to ask about 48 rather than 42 so this is clear.