Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make lesson suitable for teaching with locally-built (serverless) pages #159

Merged
merged 256 commits into from
Feb 16, 2023

Conversation

tobyhodges
Copy link
Member

Like we did in swcarpentry/shell-novice#1146, this PR makes the lesson suitable for building locally. It:

  • updates the lesson template
  • remove permalink and layout from Extras and Setup pages
  • updates internal links to the Reference page to keep them from breaking

I built the site locally and everything seems to be working, but I'll run another check for broken links if and when this has been merged.

ErinBecker and others added 30 commits February 5, 2018 10:18
Bring in latest changes to styles repository
translate 'finish' to 'final
translate overview and teaching
_config.yml: no 'mailto' in 'email'
fmichonneau and others added 23 commits August 13, 2020 07:51
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: François Michonneau <francois.michonneau@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
When 'Website' action tests a lesson, it checks out repositories into the current working directory: 'lesson' directory doesn't exist.
As a result, steps that use "lesson" as the working directory fail.
… gh-pages"

This reverts commit 2c6b97e, reversing
changes made to 53e9913.
@tobyhodges tobyhodges requested a review from gcapes October 27, 2020 10:15
@tobyhodges
Copy link
Member Author

new & improved PR: now with corrected code block class tags 😁

@gcapes
Copy link
Contributor

gcapes commented Mar 2, 2021

This lesson currently builds on my system, as does the shell lesson. The MATLAB lesson doesn't following a PR that looks a lot like this one. I anticipate this PR being similar, given it also has a bazillion commits rather than the two commits on the shell lesson PR.

I'm happy to look at this if someone will help with the Ruby/Jekyll side, but really there should be a separate PR for lesson template stuff, and for building locally.

@gcapes gcapes merged commit 4f9c812 into gh-pages Feb 16, 2023
@gcapes gcapes deleted the remove_custom_permalinks branch February 16, 2023 09:21
zkamvar pushed a commit that referenced this pull request Apr 24, 2023
make lesson suitable for teaching with locally-built (serverless) pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.