Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(visit): Add path-aware variants #5073

Merged
merged 205 commits into from
Jul 5, 2022
Merged

feat(visit): Add path-aware variants #5073

merged 205 commits into from
Jul 5, 2022
+1,428 −213

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 30, 2022 •
edited
Loading

TODOs

  • Add a method to convert node to AstKind
  • Add a method to convert node to AstNodeRef
  • Adjust other codegen parts to use __ast_path
  • Add cfg(feature = "path") to items. (I didn’t do this because it makes development harder)
  • Implement swc_visit::AstKindPath
  • Implement swc_visit::AstNodePath

@kdy1 kdy1 added this to the Planned milestone Jun 30, 2022
@kdy1 kdy1 force-pushed the smarter-visitor branch from c333d41 to 1a4d05e Compare July 1, 2022 03:33
kdy1
kdy1 commented Jul 5, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_visit

@kdy1 kdy1 marked this pull request as ready for review July 5, 2022 04:09
@kdy1 kdy1 enabled auto-merge (squash) July 5, 2022 04:10
swc-bot
swc-bot reviewed Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 modified the milestone: Planned Jul 5, 2022
swc-bot
swc-bot reviewed Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 204d742 into swc-project:main Jul 5, 2022
@kdy1 kdy1 deleted the smarter-visitor branch July 5, 2022 04:38
@kdy1 kdy1 modified the milestones: Planned, v1.2.209 Jul 5, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kwonoj kwonoj kwonoj left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.209
Development

Successfully merging this pull request may close these issues.
4 participants
@kdy1 @Austaras @kwonoj @swc-bot