This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
rootston: fix crash with fullscreen surfaces #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Maybe we could un-fullscreen when un-mapping views instead? |
|
Okay, I see that this also happens before views are mapped. Can you move the check at the beginning of |
valpackett
force-pushed
the
fix-retroarch-crash
branch
from
7df09c1 to
4b2b8a9
Compare
|
Updated. Does this fix ioq3? |
emersion
reviewed
Jan 4, 2019
|
Yes, this does fix ioquake3 :) |
Fixes fullscreen mode in e.g. RetroArch and ioquake3.
valpackett
force-pushed
the
fix-retroarch-crash
branch
from
4b2b8a9 to
57edfac
Compare
emersion
approved these changes
Jan 4, 2019
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RetroArch fullscreen mode.