Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: OpenAiEmbedding issue #511 and appropriate test #514

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix: OpenAiEmbedding issue #511 and appropriate test #514

merged 2 commits into from
Sep 23, 2024

Conversation

RafaelJohn9
Copy link
Contributor

fixes #511

@RafaelJohn9
Fix: OpenAiEmbedding issue swarmauri#511 and appropriate test
5e4961e 
Signed-off-by: RafaelJohn9 <rafaeljohb@gmail.com>
@keetrap
Copy link
Contributor

keetrap commented Sep 23, 2024

@RafaelJohn9
I apologize for the oversight in my recent contribution to the OpenAIEmbedding class. I missed setting self.model = model in the __init__ method. This needs to be corrected to ensure the specified model is used properly.

@RafaelJohn9
Copy link
Contributor Author

@RafaelJohn9 I apologize for the oversight in my recent contribution to the OpenAIEmbedding class. I missed setting self.model = model in the __init__ method. This needs to be corrected to ensure the specified model is used properly.

Fixed it

@RafaelJohn9
Fix: OpenAI embedding; correctly instatiating model attr
a8c5d4d 
Signed-off-by: RafaelJohn9 <rafaeljohb@gmail.com>
@cobycloud cobycloud merged commit 1a23e0c into swarmauri:0.4.5.dev1 Sep 23, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cobycloud cobycloud cobycloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafaelJohn9 @keetrap @cobycloud