-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds description about various options available with the acts_as_list method #168
Conversation
@@ -85,6 +85,15 @@ class TodoItem < ActiveRecord::Base | |||
end | |||
``` | |||
|
|||
## More Options | |||
You can pass the following options with **acts_as_list** class method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this line.
This documentation is best left to the code. By putting it in README, we're only repeating ourselves. |
I think README file is to help developers understand how to use the gem. |
I kind of agree with @udit7590, it is handy to have the options documented in the README. Up to you though Swanand. :) |
👍 |
Alright, let's put it in. @udit7590 Can you make the fix I commented on, and then squash the two commits? I am generally not in favour of squashing, but the commits here are tiny enough to warrant a squash. |
…t method Improves message
620ecd5
to
6ccb97e
Compare
@swanandp Squashed and fixed the changes. |
Alright, merging this in. |
Adds description about various options available with the acts_as_list method
No description provided.