fix some XSS with improved handlebar template escaping #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not an expert, but using HTML escaping seems like the right thing to me. |
|
I'm new to gulp stuff and I don't trust my build pipeline a ton (windows while everyone one else is osx these days), so I didn't go for making the dist. I kinda expect that'd be better as a CI build job task, but can give it a go if needed. It looks like the develop_2.0 branch has been retired in favor of merging to master. https://groups.google.com/forum/#!topic/swagger-swaggersocket/dEwm8J5p7Ag/discussion |
Closed
|
i believe this has been handled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will address many cases of cross-site scripting via swagger api-data. I would love feedback from someone more familiar with the project.
The root of many of our XSS issues appears due to Handlebar templates.
We have a few fields where we are likely incorrectly disabling Handlebar's HTML escaping by using "triple-stash"
{{{ }}}(http://handlebarsjs.com/#html-escaping)Please note: this PR doesn't fix signature.handlebars. The signature feature still needs more attention to fix a related XSS vulnerability while keeping functionality.
Related:
#830