feat: add keyboard navigation to svelte inspector and improve a11y #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffrich
reviewed
Sep 15, 2022
…n navigated element, clamp y pos of bubble to viewport
|
i also cleaned up the changeset files, hoping it creates a cleaner changelog for 1.1.0. given inspector is still experimental and is going to move into a separate package at a later stage, should we use patch instead? |
|
I think it'd be fine if we stick as a patch 👍 |
dominikg
changed the title
bluwy
approved these changes
Sep 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR follows up on #436 to complete keyboard only navigation and a11y improvements
There are two new options for inspector. navKeys (default to arrow keys) and openKey (defaults to Enter).
Read more here https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/config.md#inspector
This allows you to operate svelte-inspector by keyboard only.
In addition the currently selected dom node's file position is announced via aria-live for screen-readers.