Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure $state.snapshot clones holey arrays correctly #14657

Merged
merged 4 commits into from
Dec 10, 2024
Merged

fix: ensure $state.snapshot clones holey arrays correctly #14657

merged 4 commits into from
Dec 10, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Dec 10, 2024

Fixes #14653

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b5148d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14657

@Rich-Harris Rich-Harris merged commit fb879dd into main Dec 10, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the snapshot-array-holes branch December 10, 2024 19:21
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$state.snapshot does not preserve holes in a sparse array
2 participants
@trueadm @Rich-Harris