-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
🦋 Changeset detectedLatest commit: 1ee50e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit:
|
For whatever reason this works in CI..... |
I believe @dominikg setup the tests for |
As soon as I switch this line from using
I tried to reproduce the error in a codespace, but everything seems to work there, as in CI (well expect for the storybook tests, but I'm not interested in these atm). Also tried a to do a fresh clone on my machine, but I only got the same error as before. Edit: As shown in the tests for |
tests for create-svelte are special as you have to prevent the local monorepo packages from bleeding in. so they generate a separate monorepo root in a temp dir. its weird and pretty specific to create-svelte. a similar pattern could be used for svelte-add but not sure you need it unless you want e2e-tests that validate the adder worked by installing and building the e2e project again. but I'd be fine with snapshots validating expected file changes |
Closing in favor of #544 |
Relates / in preparation for #461
Command to test adders locally will slightly change with this:
will now be
You can also use
pnpm test:ui
which will also spin up vitest ui, although the ui is pretty barebones and does not allow running filtered tests in example.Currently a draft, as I needed to switch from
pnpm
tonpm
for the testing in order to make everything work. Now trying to figure out what causes the problem