Classlib: Fix 2 issues regarding Rest and patterns #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2013 14:30
Necessary because the collect func may return a Rest. Previously, this Rest was not 'process'ed, breaking math operations on the return value. At first, I thought this might also be needed for Pselect and Preject, but these patterns only suppress output values, not alter them. Rests should already have been 'process'ed by the input stream.
danstowell
added a commit
that referenced
this pull request
Sep 21, 2013
Classlib: Fix 2 issues regarding Rest and patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest({ 5.rand })orRest(Pseries(1, 1, inf).asStream), but this wasn't supported before. Now you can.1a. A possible refinement would be to create the Rest with
^super.new(dur.asStream)-- this is probably a good idea, but I'm not sure, so I'm keeping it out of this pull request for now.